qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Jan Kiszka <jan.kiszka@web.de>,
	qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] io-thread optimizations
Date: Thu, 14 Apr 2011 08:59:45 -0500	[thread overview]
Message-ID: <4DA6FDD1.4040307@codemonkey.ws> (raw)
In-Reply-To: <4DA6FA65.4010503@redhat.com>

On 04/14/2011 08:45 AM, Avi Kivity wrote:
> On 04/14/2011 10:14 AM, Jan Kiszka wrote:
>> On 2011-04-13 22:16, Aurelien Jarno wrote:
>> >  On Mon, Apr 11, 2011 at 10:27:41PM +0200, Jan Kiszka wrote:
>> >>  These patches were posted before. They bring down the overhead of 
>> the
>> >>  io-thread mode for TCG here, specifically when emulating SMP.
>> >>
>> >>  The major change in this version, besides rebasing, is the 
>> exclusion of
>> >>  KVM from the main loop polling optimization.
>> >>
>> >>
>> >>
>> >>  Jan Kiszka (3):
>> >>    Do not drop global mutex for polled main loop runs
>> >>    Poll main loop after I/O events were received
>> >>    Do not kick vcpus in TCG mode
>> >>
>> >>   cpus.c   |    2 +-
>> >>   sysemu.h |    2 +-
>> >>   vl.c     |   22 ++++++++++++++++------
>> >>   3 files changed, 18 insertions(+), 8 deletions(-)
>> >>
>> >
>> >  Thanks for working on improving the io-thread with TCG. Your patches
>> >  make sense, but they don't seems to fix the slowdown observed when
>> >  enabling the io-thread. Well maybe they were not supposed to. This is
>> >  for example the results of netperf between guest and host using 
>> virtio:
>> >
>> >  no io-thread            122 MB/s
>> >  io-thread                97 MB/s
>> >  io-thread + patches      98 MB/s
>> >
>>
>> Can you capture ftraces of io-thread enabled&  disabled runs? They just
>> need to cover a hand full of frames.
>>
>
> Also interesting would be the context switch rates on the host.
>
> If they're large, perhaps using user-space threading instead of native 
> threads would help.

I still suspect mitigation as the culprit here.  Select is going to get 
to run more often which means more interrupt generation.

I bet if you count the number of packets per interrupt/notify you'll 
find that less batching is occurring.

Regards,

Anthony Liguori

  reply	other threads:[~2011-04-14 13:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 20:27 [Qemu-devel] [PATCH v2 0/3] io-thread optimizations Jan Kiszka
2011-04-11 20:27 ` [Qemu-devel] [PATCH v2 1/3] Do not drop global mutex for polled main loop runs Jan Kiszka
2011-04-11 20:27 ` [Qemu-devel] [PATCH v2 2/3] Poll main loop after I/O events were received Jan Kiszka
2011-04-11 20:27 ` [Qemu-devel] [PATCH v2 3/3] Do not kick vcpus in TCG mode Jan Kiszka
2011-04-12  7:09 ` [Qemu-devel] [PATCH v2 0/3] io-thread optimizations Paolo Bonzini
2011-04-13 20:16 ` Aurelien Jarno
2011-04-14  7:14   ` Jan Kiszka
2011-04-14 13:45     ` Avi Kivity
2011-04-14 13:59       ` Anthony Liguori [this message]
2011-04-14 14:05         ` Avi Kivity
2011-04-25 18:35     ` Aurelien Jarno
2011-04-26  7:36       ` Jan Kiszka
2011-06-25  8:38   ` Jan Kiszka
2011-06-25 22:44     ` Andreas Färber
2011-06-26  9:11       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA6FDD1.4040307@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).