qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] multiboot: Support quotable commas in module list
Date: Fri, 15 Apr 2011 15:17:28 +0200	[thread overview]
Message-ID: <4DA84568.2050301@redhat.com> (raw)
In-Reply-To: <1302854186-6772-1-git-send-email-adam@os.inf.tu-dresden.de>

Am 15.04.2011 09:56, schrieb Adam Lackorzynski:
> Support quoting of ',' (and '\') to allow commas in the parameter list of
> modules.
> 
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>

Other options in qemu use double commas for escaping. So maybe reusing
get_opt_value() would make things more consistent. It also has the
advantage that double commas don't need additional escape characters for
the shell.

On the other hand, using backslashes for escaping is probably more
familiar for most people, so I don't have a very strong opinion on it.

Kevin

  parent reply	other threads:[~2011-04-15 13:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  7:56 [Qemu-devel] [PATCH] multiboot: Support quotable commas in module list Adam Lackorzynski
2011-04-15  9:09 ` Stefan Hajnoczi
2011-04-15 13:17 ` Kevin Wolf [this message]
2011-04-16  9:42   ` Adam Lackorzynski
2011-04-16 11:21     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA84568.2050301@redhat.com \
    --to=kwolf@redhat.com \
    --cc=adam@os.inf.tu-dresden.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).