From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60950)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1QBn5D-0003Sx-1A
	for qemu-devel@nongnu.org; Mon, 18 Apr 2011 07:57:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1QBn5C-0007QQ-6W
	for qemu-devel@nongnu.org; Mon, 18 Apr 2011 07:57:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1QBn5B-0007Q3-SD
	for qemu-devel@nongnu.org; Mon, 18 Apr 2011 07:57:34 -0400
Message-ID: <4DAC2708.7040302@redhat.com>
Date: Mon, 18 Apr 2011 13:56:56 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <cd5f9f1eb8708c093c922663adbdaf38e475d60d.1303127142.git.amit.shah@redhat.com>
In-Reply-To: <cd5f9f1eb8708c093c922663adbdaf38e475d60d.1303127142.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] atapi: Add 'medium ready' to 'medium not
 ready' transition on cd change
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On 04/18/11 13:45, Amit Shah wrote:
> MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY
> command.  Going from medium not ready to medium ready states is
> communicated by throwing an error.
> 
> This adds the missing 'tray opened' event that we fail to report to
> guests.  After doing this, older Linux guests properly revalidate a disc
> on the change command.  HSM violation errors, which caused Linux guests
> to do a soft-reset of the link, also go away:
> 
> ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6
> sr 1:0:0:0: CDB: Test Unit Ready: 00 00 00 00 00 00
> ata2.00: cmd a0/00:00:00:00:00/00:00:00:00:00/a0 tag 0
>          res 01/60:00:00:00:00/00:00:00:00:00/a0 Emask 0x3 (HSM violation)
> ata2.00: status: { ERR }
> ata2: soft resetting link
> ata2.00: configured for MWDMA2
> ata2: EH complete
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  hw/ide/core.c |   20 ++++++++++++++++----
>  1 files changed, 16 insertions(+), 4 deletions(-)

Looks good to me.

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>