From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBvIX-0006AD-4y for qemu-devel@nongnu.org; Mon, 18 Apr 2011 16:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QBvIV-0002AK-Nt for qemu-devel@nongnu.org; Mon, 18 Apr 2011 16:43:53 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:59856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QBvIV-0002AE-C6 for qemu-devel@nongnu.org; Mon, 18 Apr 2011 16:43:51 -0400 Message-ID: <4DACA27B.7090906@mail.berlios.de> Date: Mon, 18 Apr 2011 22:43:39 +0200 From: Stefan Weil MIME-Version: 1.0 References: <20110411192841.21414.46756.stgit@s20.home> <4DA35B0F.3040904@codemonkey.ws> <1302551871.3589.83.camel@x201> <1303147508.3110.75.camel@x201> <4DAC761E.1040609@codemonkey.ws> In-Reply-To: <4DAC761E.1040609@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alex Williamson , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, mcb30@ipxe.org Am 18.04.2011 19:34, schrieb Anthony Liguori: > On 04/18/2011 12:25 PM, Alex Williamson wrote: >> On Mon, 2011-04-11 at 13:57 -0600, Alex Williamson wrote: >>> On Mon, 2011-04-11 at 14:48 -0500, Anthony Liguori wrote: >>>> On 04/11/2011 02:35 PM, Alex Williamson wrote: >>>>> This series replaces our current gPXE based PXE ROMs with iPXE >>>>> versions from the iPXE project (http://ipxe.org). This version >>>>> adds ipxe to our submodules so it can be easily included in >>>>> releases. I'm still including a script for updating these, >>>>> perhaps someone better with Makefiles can eventually adopt this >>>>> to a build target. >>>>> >>>>> This email series is mainly for reference, there's too much >>>>> renaming and replacing binary files to send out to the mailing >>>>> list. I'll strip out the binaries here so the rest can be >>>>> reviewed. For the real code, please pull: >>>>> >>>>> git://github.com/awilliam/qemu.git (ipxe branch) >>>>> >>>>> Thanks to Anthony for already setting up an ipxe mirror. >>>>> Thanks, >>>> >>>> Looks good to me. How different is this from what we've been shipping? >>>> Have you tested PXE boot from the builtin TFTP server and from an >>>> external one (like dnsmasq)? >>> >>> We were shipping v0.9.9, which was tagged 10/2009. There's been a gpxe >>> v1.0.0 release since then, plus the split between ipxe and gpxe. I >>> think Michael is hoping to have a release soon, but the code feels >>> pretty stable to me as is. >>> >>> I've tested external booting from dhcp/tftp server for all the NICs. >>> I'll make a pass through testing with the builtin server and report >>> back. Thanks, >> >> Ping, any reason this isn't going in? Testing passed, I updated the >> script to use bash and alphabetized the Makefile per Stefan Weil's >> suggestions. These are updated in the above github tree. Let me know. >> Thanks, > > I actually was just testing the github tree. Unfortunately, it looks > like there's something broken. > > You renamed all of the pxe roms to end with .bin but Makefile still > refers to everything as .rom. > > This makes make install break along with building from a separate build > directory. > > Regards, > > Anthony Liguori Acked-by: Stefan Weil The patch renames .bin to .rom, so the Makefile should be ok. Regards, Stefan Weil