From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCOHT-0002hq-Dn for qemu-devel@nongnu.org; Tue, 19 Apr 2011 23:40:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCOHS-0005hX-Ef for qemu-devel@nongnu.org; Tue, 19 Apr 2011 23:40:43 -0400 Received: from [222.73.24.84] (port=63346 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCOHS-0005hL-5G for qemu-devel@nongnu.org; Tue, 19 Apr 2011 23:40:42 -0400 Message-ID: <4DAE3CB4.6000302@cn.fujitsu.com> Date: Wed, 20 Apr 2011 09:53:56 +0800 From: Lai Jiangshan MIME-Version: 1.0 References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99C309.6060905@codemonkey.ws> In-Reply-To: <4D99C309.6060905@codemonkey.ws> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lai Jiangshan , kvm@vger.kernel.org, qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , Avi Kivity On 04/04/2011 09:09 PM, Anthony Liguori wrote: > On 04/04/2011 07:19 AM, Markus Armbruster wrote: >> [Note cc: Anthony] >> >> "Daniel P. Berrange" writes: >> >>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: >>>> From: Lai Jiangshan >>>> Date: Mon, 7 Mar 2011 17:05:15 +0800 >>>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command >>>> >>>> inject-nmi command injects an NMI on all CPUs of guest. >>>> It is only supported for x86 guest currently, it will >>>> returns "Unsupported" error for non-x86 guest. >>>> >>>> --- >>>> hmp-commands.hx | 2 +- >>>> monitor.c | 18 +++++++++++++++++- >>>> qmp-commands.hx | 29 +++++++++++++++++++++++++++++ >>>> 3 files changed, 47 insertions(+), 2 deletions(-) >>> Does anyone have any feedback on this addition, or are all new >>> QMP patch proposals blocked pending Anthony's QAPI work ? >> That would be bad. Anthony, what's holding this back? > > It doesn't pass checkpath.pl. > > But I'd also expect this to come through Luiz's QMP tree. > > Regards, > > Anthony Liguori > Hi, Anthony, I cannot find checkpath.pl in the source tree. And how/where to write errors descriptions? Is the following description suitable? ## # @inject-nmi: # # Inject an NMI on the guest. # # Returns: Nothing on success. # If the guest(non-x86) does not support NMI injection, Unsupported # # Since: 0.15.0 ## { 'command': 'inject-nmi' } Thanks, Lai