From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCp8h-0004Mh-8f for qemu-devel@nongnu.org; Thu, 21 Apr 2011 04:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCp8g-0002Rp-BT for qemu-devel@nongnu.org; Thu, 21 Apr 2011 04:21:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCp8f-0002RL-Ta for qemu-devel@nongnu.org; Thu, 21 Apr 2011 04:21:26 -0400 Message-ID: <4DAFE8DD.7090803@redhat.com> Date: Thu, 21 Apr 2011 10:20:45 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1303138953-1334-1-git-send-email-mdroth@linux.vnet.ibm.com> <1303138953-1334-9-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1303138953-1334-9-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH v2 08/17] qapi: fix Error usage in qemu-sockets.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org On 04/18/11 17:02, Michael Roth wrote: > Fix spurious errors due to not initializing Error pointer to NULL before > checking for errors. > > Signed-off-by: Michael Roth > --- > qemu-sockets.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-sockets.c b/qemu-sockets.c > index dc8beeb..e709e5f 100644 > --- a/qemu-sockets.c > +++ b/qemu-sockets.c > @@ -630,7 +630,7 @@ int unix_connect(const char *path) > { > QemuOpts *opts; > int sock; > - Error *err; > + Error *err = NULL; > > opts = qemu_opts_create(&dummy_opts, NULL, 0, &err); > if (err) { This one really should go into the tree asap, even if the rest of the virt agent patches are still pending. Reviewed-by: Jes Sorensen