From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCpbw-0003Ui-AH for qemu-devel@nongnu.org; Thu, 21 Apr 2011 04:51:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCpbv-0007rD-Fz for qemu-devel@nongnu.org; Thu, 21 Apr 2011 04:51:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCpbv-0007r7-2y for qemu-devel@nongnu.org; Thu, 21 Apr 2011 04:51:39 -0400 Message-ID: <4DAFEFEA.9020102@redhat.com> Date: Thu, 21 Apr 2011 10:50:50 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1303138953-1334-1-git-send-email-mdroth@linux.vnet.ibm.com> <1303138953-1334-16-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1303138953-1334-16-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH v2 15/17] guest agent: qemu-ga daemon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org On 04/18/11 17:02, Michael Roth wrote: > +static const char *ga_log_level_str(GLogLevelFlags level) > +{ > + switch (level & G_LOG_LEVEL_MASK) { > + case G_LOG_LEVEL_ERROR: return "error"; > + case G_LOG_LEVEL_CRITICAL: return "critical"; > + case G_LOG_LEVEL_WARNING: return "warning"; > + case G_LOG_LEVEL_MESSAGE: return "message"; > + case G_LOG_LEVEL_INFO: return "info"; > + case G_LOG_LEVEL_DEBUG: return "debug"; > + default: return "user"; > + } Urgh! No two statements on the same line please! Jes