From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCtns-00019s-LP for qemu-devel@nongnu.org; Thu, 21 Apr 2011 09:20:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QCtnr-0001uQ-TS for qemu-devel@nongnu.org; Thu, 21 Apr 2011 09:20:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QCtnr-0001uA-JG for qemu-devel@nongnu.org; Thu, 21 Apr 2011 09:20:15 -0400 Message-ID: <4DB02EE9.1030005@redhat.com> Date: Thu, 21 Apr 2011 15:19:37 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1303138953-1334-1-git-send-email-mdroth@linux.vnet.ibm.com> <1303138953-1334-13-git-send-email-mdroth@linux.vnet.ibm.com> <4DAFEE7F.5030607@redhat.com> <4DB02E0E.5080809@linux.vnet.ibm.com> In-Reply-To: <4DB02E0E.5080809@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH v2 12/17] guest agent: worker thread class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org On 04/21/11 15:15, Michael Roth wrote: > On 04/21/2011 03:44 AM, Jes Sorensen wrote: >> and again.... I'll stop. Basically there really should be no references >> to pthread_* > > This is on the guest side of things where I'm trying to use GLib > wherever possible to keep things somewhat portable: logging/list > utilities/io events/etc. And I *really* wanted to use GThreads here, but > the problem is that GThread does not have any sane means to kill off a > thread when a timeout occurs: there's no analogue to pthread_cancel(), > and to use signals you need to break the abstraction to get the > underlying pid. The new QemuThread stuff is using GThread underneath the > covers so same limitation there. > > pthreads provides these things and is fairly portable however, so I > opted to make it an explicit dependency on the guest side. So > glib+pthreads are the current dependencies. That is really unfortunate - is there no way around it? It really would be ideal if we could build the guest relying on QemuThreads for portability. Either way, please fix the include issue. Jes