From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1QD9ux-0004li-EY
	for qemu-devel@nongnu.org; Fri, 22 Apr 2011 02:32:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1QD9uw-00089Z-He
	for qemu-devel@nongnu.org; Fri, 22 Apr 2011 02:32:39 -0400
Received: from e8.ny.us.ibm.com ([32.97.182.138]:38603)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1QD9uw-00089R-AC
	for qemu-devel@nongnu.org; Fri, 22 Apr 2011 02:32:38 -0400
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3M67223031699
	for <qemu-devel@nongnu.org>; Fri, 22 Apr 2011 02:07:02 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p3M6SoJL712892
	for <qemu-devel@nongnu.org>; Fri, 22 Apr 2011 02:32:34 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p3LDLYvc018389
	for <qemu-devel@nongnu.org>; Thu, 21 Apr 2011 10:21:35 -0300
Message-ID: <4DB02F5D.7020204@linux.vnet.ibm.com>
Date: Thu, 21 Apr 2011 08:21:33 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1303138953-1334-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1303138953-1334-16-git-send-email-mdroth@linux.vnet.ibm.com>
	<4DAFEFEA.9020102@redhat.com>
In-Reply-To: <4DAFEFEA.9020102@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH v2 15/17] guest agent: qemu-ga daemon
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org

On 04/21/2011 03:50 AM, Jes Sorensen wrote:
> On 04/18/11 17:02, Michael Roth wrote:
>> +static const char *ga_log_level_str(GLogLevelFlags level)
>> +{
>> +    switch (level&  G_LOG_LEVEL_MASK) {
>> +        case G_LOG_LEVEL_ERROR:     return "error";
>> +        case G_LOG_LEVEL_CRITICAL:  return "critical";
>> +        case G_LOG_LEVEL_WARNING:   return "warning";
>> +        case G_LOG_LEVEL_MESSAGE:   return "message";
>> +        case G_LOG_LEVEL_INFO:      return "info";
>> +        case G_LOG_LEVEL_DEBUG:     return "debug";
>> +        default:                    return "user";
>> +    }
>
> Urgh!
>
> No two statements on the same line please!

Darn, I was hoping my surplus on coding style points for actually 
indenting my case statements would make up for that :)

>
> Jes