From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QD0xr-000485-4L for qemu-devel@nongnu.org; Thu, 21 Apr 2011 16:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QD0xp-0002r4-Uo for qemu-devel@nongnu.org; Thu, 21 Apr 2011 16:59:02 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:34069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QD0xp-0002qm-OQ for qemu-devel@nongnu.org; Thu, 21 Apr 2011 16:59:01 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3LKkcGh012666 for ; Thu, 21 Apr 2011 14:46:38 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p3LKwdU8154046 for ; Thu, 21 Apr 2011 14:58:40 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3LKwYJD012678 for ; Thu, 21 Apr 2011 14:58:34 -0600 Message-ID: <4DB09A79.8010808@linux.vnet.ibm.com> Date: Thu, 21 Apr 2011 15:58:33 -0500 From: Michael Roth MIME-Version: 1.0 References: <1303138953-1334-1-git-send-email-mdroth@linux.vnet.ibm.com> <4DB03ADF.7060800@redhat.com> In-Reply-To: <4DB03ADF.7060800@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH v2 00/11] QEMU Guest Agent: QMP-based host/guest communication (virtagent) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: aliguori@linux.vnet.ibm.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org On 04/21/2011 09:10 AM, Jes Sorensen wrote: > On 04/18/11 17:02, Michael Roth wrote: >> These apply on top of Anthony's glib tree, commit 03d5927deb5e6baebaade1b4c8ff2428a85e125c currently, and can also be obtained from: >> git://repo.or.cz/qemu/mdroth.git qga_v2 >> >> Patches 1-8 are general json/QAPI-related fixes. Anthony, please consider pulling these into your glib tree. The json fix-ups may need further evaluation, but I'm confident they're at least an improvement. The QAPI ones are mostly trivial fix-ups. >> >> Changes since V1: >> >> - Added guest agent worker thread to execute RPCs in the guest. With this in place we have a reliable timeout mechanism for hung commands, currently set at 30 seconds. >> - Add framework for registering init/cleanup routines for stateful RPCs to clean up after themselves after a timeout. >> - Added the following RPCs: guest-file-{open,close,read,write,seek}, guest-shutdown, guest-info, and removed stubs for guest-view-file (now deprecated) >> - Added GUEST_AGENT_UP/GUEST_AGENT_DOWN QMP events >> - Switched to a TCP-style host-initiated 3-way handshake for channel negotiation, this simplifies client negotiation/interaction over the wire >> - Added configurable log level/log file/pid file options for guest agent >> - Various fixes for bugs/memory leaks and checkpatch.pl fixups >> >> ISSUES/TODOS: >> >> - Fix QMP proxy handling of error responses sent by guest agent, currently ignored >> - Add unit tests for guest agent wire protocol >> - Add unit tests for QMP interfaces >> - Add host-side timeout mechanism for async QMP commands >> - Return error for guest commands if guest up event has not yet been recieved >> - Make QMP param names more consistent between related commands >> - Clean up logging > > Michael, > > One thing I cannot seem to figure out with this tree - the agent > commands do not seem to show up in the monitor? What am I missing? Hmm, for some reason this email never hit my inbox. You mean with the human monitor? Currently, with these new patches, we're QMP only. And most of the command names/semantics have changed as well. The qapi-schema.json changes in patch 16 have the new prototypes, and the 0 patch has some usage examples. > > Cheers, > Jes > >