From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEKG7-00080s-8y for qemu-devel@nongnu.org; Mon, 25 Apr 2011 07:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEKG5-0003C5-U6 for qemu-devel@nongnu.org; Mon, 25 Apr 2011 07:47:19 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:50254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEKG5-0003Bn-Bi for qemu-devel@nongnu.org; Mon, 25 Apr 2011 07:47:17 -0400 Message-ID: <4DB55F1A.2090203@web.de> Date: Mon, 25 Apr 2011 13:46:34 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1303729257-9034-1-git-send-email-ohmura.kei@lab.ntt.co.jp> <1303729257-9034-13-git-send-email-ohmura.kei@lab.ntt.co.jp> In-Reply-To: <1303729257-9034-13-git-send-email-ohmura.kei@lab.ntt.co.jp> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFE18484E71E8CB6162890753" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: OHMURA Kei Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, Yoshiaki Tamura , vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com, quintela@redhat.com, tamura.yoshiaki@gmail.com, avi@redhat.com, pbonzini@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFE18484E71E8CB6162890753 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-04-25 13:00, OHMURA Kei wrote: > From: Yoshiaki Tamura >=20 > Record mmio write event to replay it upon failover. >=20 > Signed-off-by: Yoshiaki Tamura > Signed-off-by: OHMURA Kei > --- > exec.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >=20 > diff --git a/exec.c b/exec.c > index c3dc68a..3c3cece 100644 > --- a/exec.c > +++ b/exec.c > @@ -33,6 +33,7 @@ > #include "osdep.h" > #include "kvm.h" > #include "qemu-timer.h" > +#include "event-tap.h" > #if defined(CONFIG_USER_ONLY) > #include > #include > @@ -3736,6 +3737,9 @@ void cpu_physical_memory_rw(target_phys_addr_t ad= dr, uint8_t *buf, > io_index =3D (pd >> IO_MEM_SHIFT) & (IO_MEM_NB_ENTRIES= - 1); > if (p) > addr1 =3D (addr & ~TARGET_PAGE_MASK) + p->region_o= ffset; > + > + event_tap_mmio(addr, buf, len); > + You know that this is incomplete? A few devices are calling st*_phys directly, specifically virtio. What kind of mmio should be traced here, device or CPU originated? Or bot= h? Jan --------------enigFE18484E71E8CB6162890753 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk21Xx0ACgkQitSsb3rl5xSvLgCg2I13IRLMjYJe5LHzc7JsCU24 JlUAoKMJbq8LRg7s04M0V7rc1olCkk5Q =P1LJ -----END PGP SIGNATURE----- --------------enigFE18484E71E8CB6162890753--