From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Mark McLoughlin" <markmc@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic
Date: Mon, 25 Apr 2011 08:42:17 -0500 [thread overview]
Message-ID: <4DB57A39.1030508@codemonkey.ws> (raw)
In-Reply-To: <BANLkTik1GXp4D-TJAOXFmKYWuo1yMXs1ew@mail.gmail.com>
On 04/25/2011 08:40 AM, Stefan Hajnoczi wrote:
> 2011/4/25 Nguyễn Thái Ngọc Duy<pclouds@gmail.com>:
>> Dropping packets is sometimes perferred behavior. Add drop_packets
>> parameter to NICConf struct and let nic simulation decide how to use
>> it.
>>
>> Only e1000 supports this for now.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy<pclouds@gmail.com>
>> ---
>> Documentation is missing, but I'm not even sure if there's any other
>> user who finds this useful.
>
> Can you explain why you are adding this? You are trying to bypass the
> send queue and drop packets instead?
And some performance results always help with this sort of thing.
Regards,
Anthony Liguori
>
> Stefan
>
next prev parent reply other threads:[~2011-04-25 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 2:10 [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic Nguyễn Thái Ngọc Duy
2011-04-25 13:40 ` Stefan Hajnoczi
2011-04-25 13:42 ` Anthony Liguori [this message]
2011-04-25 14:06 ` Nguyen Thai Ngoc Duy
2011-04-26 9:14 ` Stefan Hajnoczi
2011-04-26 10:07 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB57A39.1030508@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=markmc@redhat.com \
--cc=pclouds@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).