From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEM3R-0002pR-G6 for qemu-devel@nongnu.org; Mon, 25 Apr 2011 09:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEM3Q-0005pn-Io for qemu-devel@nongnu.org; Mon, 25 Apr 2011 09:42:21 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:51802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEM3Q-0005pd-GP for qemu-devel@nongnu.org; Mon, 25 Apr 2011 09:42:20 -0400 Received: by gwb19 with SMTP id 19so771527gwb.4 for ; Mon, 25 Apr 2011 06:42:19 -0700 (PDT) Message-ID: <4DB57A39.1030508@codemonkey.ws> Date: Mon, 25 Apr 2011 08:42:17 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1303697435-12542-1-git-send-email-pclouds@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] net: add drop_packets parameter to -net nic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?UTF-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= , Mark McLoughlin , qemu-devel@nongnu.org On 04/25/2011 08:40 AM, Stefan Hajnoczi wrote: > 2011/4/25 Nguyễn Thái Ngọc Duy: >> Dropping packets is sometimes perferred behavior. Add drop_packets >> parameter to NICConf struct and let nic simulation decide how to use >> it. >> >> Only e1000 supports this for now. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> Documentation is missing, but I'm not even sure if there's any other >> user who finds this useful. > > Can you explain why you are adding this? You are trying to bypass the > send queue and drop packets instead? And some performance results always help with this sort of thing. Regards, Anthony Liguori > > Stefan >