From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEdqd-0000DI-R5 for Qemu-devel@nongnu.org; Tue, 26 Apr 2011 04:42:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEdqc-0002tx-Sp for Qemu-devel@nongnu.org; Tue, 26 Apr 2011 04:42:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEdqc-0002tf-II for Qemu-devel@nongnu.org; Tue, 26 Apr 2011 04:42:18 -0400 Message-ID: <4DB685F7.7020603@redhat.com> Date: Tue, 26 Apr 2011 10:44:39 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1303666738-26558-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1303666738-26558-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qed: Fix consistency check on 32-bit hosts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Qemu-devel@nongnu.org Am 24.04.2011 19:38, schrieb Stefan Hajnoczi: > The qed_bytes_to_clusters() function is normally used with size_t > lengths. Consistency check used it with file size length and therefore > failed on 32-bit hosts when the image file is 4 GB or more. > > Make qed_bytes_to_clusters() explicitly 64-bit and update consistency > check to keep 64-bit cluster counts. > > Reported-by: Michael Tokarev > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin