From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: xming <xmingske@gmail.com>, qemu-devel <qemu-devel@nongnu.org>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] kvm crashes with spice while loading qxl
Date: Tue, 26 Apr 2011 11:43:27 +0200 [thread overview]
Message-ID: <4DB693BF.1020202@redhat.com> (raw)
In-Reply-To: <4DB68B05.1090600@siemens.com>
On 04/26/11 11:06, Jan Kiszka wrote:
> On 2011-04-26 10:53, Gerd Hoffmann wrote:
>>> Two general issues with dropping the global mutex like this:
>>> - The caller of mutex_unlock is responsible for maintaining
>>> cpu_single_env across the unlocked phase (that's related to the
>>> abort above).
>>
>> This is true for qemu-kvm only, right?
>
> Nope, this applies to both implementations.
Oops.
>> qemu-kvm specific patches which add the cpu_single_env tracking (not
>> polished yet) are here:
>>
>> http://cgit.freedesktop.org/spice/qemu/log/?h=spice.kvm.v28
>
> Cannot spot that quickly: In which way are they specific to qemu-kvm?
cpu_single_env bookeeping. But if upstream needs that too having
specific patches is pretty pointless. I'll go fix it up upstream then.
cheers,
Gerd
next prev parent reply other threads:[~2011-04-26 9:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTint9-P-1jD5pbXstzPcYueLHQ68Rd0T_Chz6xRN@mail.gmail.com>
2011-02-26 12:29 ` [Qemu-devel] Re: kvm crashes with spice while loading qxl Jan Kiszka
2011-02-26 14:44 ` xming
2011-02-27 19:03 ` Alon Levy
2011-02-27 19:11 ` Jan Kiszka
2011-02-27 19:16 ` Alon Levy
2011-02-27 19:27 ` Jan Kiszka
2011-02-27 19:29 ` Alon Levy
2011-02-27 19:32 ` Alon Levy
2011-03-01 12:58 ` Alon Levy
2011-03-02 8:22 ` Jan Kiszka
2011-03-02 10:56 ` Alon Levy
2011-03-02 11:34 ` Jan Kiszka
2011-03-02 12:32 ` Alon Levy
2011-02-28 12:56 ` xming
2011-03-01 3:56 ` Rick Vernam
2011-03-05 16:35 ` Marcelo Tosatti
2011-03-05 17:11 ` Paolo Bonzini
2011-03-06 10:30 ` Alon Levy
2011-03-07 16:02 ` Marcelo Tosatti
2011-03-06 10:38 ` Avi Kivity
2011-03-07 16:13 ` Marcelo Tosatti
2011-03-07 22:27 ` Paolo Bonzini
2011-03-08 9:17 ` Avi Kivity
2011-03-08 9:28 ` Paolo Bonzini
2011-03-08 9:32 ` Avi Kivity
2011-04-26 8:53 ` [Qemu-devel] " Gerd Hoffmann
2011-04-26 9:06 ` Jan Kiszka
2011-04-26 9:43 ` Gerd Hoffmann [this message]
2011-04-26 9:34 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB693BF.1020202@redhat.com \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=xmingske@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).