From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39859)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QEeo3-0002NV-IB
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 05:43:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QEeo2-0003bD-Gr
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 05:43:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38686)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QEeo2-0003au-3q
	for qemu-devel@nongnu.org; Tue, 26 Apr 2011 05:43:42 -0400
Message-ID: <4DB693BF.1020202@redhat.com>
Date: Tue, 26 Apr 2011 11:43:27 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <AANLkTint9-P-1jD5pbXstzPcYueLHQ68Rd0T_Chz6xRN@mail.gmail.com>
	<4D68F20D.2020401@web.de> <4DB687F0.20605@redhat.com>
	<4DB68B05.1090600@siemens.com>
In-Reply-To: <4DB68B05.1090600@siemens.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] kvm crashes with spice while loading qxl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: xming <xmingske@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, kvm@vger.kernel.org

On 04/26/11 11:06, Jan Kiszka wrote:
> On 2011-04-26 10:53, Gerd Hoffmann wrote:
>>> Two general issues with dropping the global mutex like this:
>>>    - The caller of mutex_unlock is responsible for maintaining
>>>      cpu_single_env across the unlocked phase (that's related to the
>>>      abort above).
>>
>> This is true for qemu-kvm only, right?
>
> Nope, this applies to both implementations.

Oops.

>> qemu-kvm specific patches which add the cpu_single_env tracking (not
>> polished yet) are here:
>>
>> http://cgit.freedesktop.org/spice/qemu/log/?h=spice.kvm.v28
>
> Cannot spot that quickly: In which way are they specific to qemu-kvm?

cpu_single_env bookeeping.  But if upstream needs that too having 
specific patches is pretty pointless.  I'll go fix it up upstream then.

cheers,
   Gerd