From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEjXE-00008B-BG for qemu-devel@nongnu.org; Tue, 26 Apr 2011 10:46:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEjXD-0000Z2-Cf for qemu-devel@nongnu.org; Tue, 26 Apr 2011 10:46:40 -0400 Received: from ssl.dlh.net ([91.198.192.8]:48789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEjXD-0000Yw-7y for qemu-devel@nongnu.org; Tue, 26 Apr 2011 10:46:39 -0400 Message-ID: <4DB6DAC8.9060101@dlh.net> Date: Tue, 26 Apr 2011 16:46:32 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1283784174-30436-1-git-send-email-bernhard.kohl@nsn.com> <4CADAE8E.2050405@redhat.com> <34941DDA-4ADD-478F-A529-2B48F4A64541@dlh.net> <4D773E9F.6060009@redhat.com> <4D77479D.9010903@nsn.com> In-Reply-To: <4D77479D.9010903@nsn.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] lsi53c895a: add support for ABORT messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bernhard Kohl Cc: ext Kevin Wolf , qemu-devel@nongnu.org, "Nicholas A. Bellinger" , Hannes Reinecke On 09.03.2011 10:25, Bernhard Kohl wrote: > Am 09.03.2011 09:47, schrieb ext Kevin Wolf: >> Am 09.03.2011 00:04, schrieb Peter Lieven: >>> Am 07.10.2010 um 13:27 schrieb Kevin Wolf: >>> >>>> Am 06.09.2010 16:42, schrieb Bernhard Kohl: >>>>> If these messages are not handled correctly the guest driver may >>>>> hang. >>>>> >>>>> Always mandatory: >>>>> - ABORT >>>>> - BUS DEVICE RESET >>>>> >>>>> Mandatory if tagged queuing is implemented (which disks usually do): >>>>> - ABORT TAG >>>>> - CLEAR QUEUE >>>>> >>>>> Signed-off-by: Bernhard Kohl >>>> Nicholas, as you seem to have touched the lsi code recently, care to >>>> review this one? Assuming that you are reasonably familiar with >>>> both the >>>> hardware and the code, you should be quicker than me with this. >>> Is there a reason why this patch was never added to the stable >>> qemu-kvm release? >>> At least int qemu-kvm-0.14.0 I still can't find it. >> The reason is that it still didn't get a review. >> > I still depend on this patch. It's needed for our legacy guest OS. > It's heavily in use here with STGT iSCSI disks via scsi-generic. i recently saw some qemu-kvm 0.12.5 guests with scsi and this patch applies crashing when we updated our backend iscsi storages. (short interrupt in traffic flow, iscsi disconnect + reconnect) i always see: lsi_scsi: error: ORDERED queue not implemented and then either the maschine just hangs or it even aborts due to this assertion: qemu-kvm-0.12.5: /usr/src/qemu-kvm-0.12.5/hw/lsi53c895a.c:596: lsi_reselect: Assertion `s->current == ((void *)0)' failed. any ideas? peter > > Bernhard >