From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset
Date: Tue, 26 Apr 2011 20:55:22 +0200 [thread overview]
Message-ID: <4DB7151A.4000401@web.de> (raw)
In-Reply-To: <BANLkTikJFu2A9aEw2niF7fciTb+yqOVm7Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On 2011-04-26 20:00, Blue Swirl wrote:
> On Tue, Apr 26, 2011 at 11:50 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Instead of having an extra reset function at machine level and special
>> code for processing INIT, move the initialization of halted into the
>> cpu reset handler.
>
> Nack. A CPU is designated as a BSP at board level. CPUs do not need to
> know about this at all.
That's why we have cpu_is_bsp() in pc.c.
Obviously, every CPU (which includes the APIC) must know if it is
supposed to be BP or AP. It would be unable to enter the right state
after reset otherwise (e.g. Intel SDM 9.1). cpu_is_bsp() is basically
reporting the result of the MP init protocol in condensed from.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-04-26 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 8:50 [Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset Jan Kiszka
2011-04-26 18:00 ` Blue Swirl
2011-04-26 18:55 ` Jan Kiszka [this message]
2011-04-26 19:59 ` Blue Swirl
2011-04-27 7:11 ` Jan Kiszka
2011-04-27 17:17 ` Blue Swirl
2011-04-27 17:32 ` Jan Kiszka
2011-04-27 18:29 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB7151A.4000401@web.de \
--to=jan.kiszka@web.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).