From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEnQh-0003Vc-LH for qemu-devel@nongnu.org; Tue, 26 Apr 2011 14:56:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEnQg-0005rq-5Q for qemu-devel@nongnu.org; Tue, 26 Apr 2011 14:56:11 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:44568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEnQf-0005rS-UJ for qemu-devel@nongnu.org; Tue, 26 Apr 2011 14:56:10 -0400 Message-ID: <4DB7151A.4000401@web.de> Date: Tue, 26 Apr 2011 20:55:22 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4DB68768.3050700@siemens.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFD63D7450029F9AAD0541748" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] target-i386: Initialize CPUState::halted in cpu_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFD63D7450029F9AAD0541748 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-04-26 20:00, Blue Swirl wrote: > On Tue, Apr 26, 2011 at 11:50 AM, Jan Kiszka w= rote: >> Instead of having an extra reset function at machine level and special= >> code for processing INIT, move the initialization of halted into the >> cpu reset handler. >=20 > Nack. A CPU is designated as a BSP at board level. CPUs do not need to > know about this at all. That's why we have cpu_is_bsp() in pc.c. Obviously, every CPU (which includes the APIC) must know if it is supposed to be BP or AP. It would be unable to enter the right state after reset otherwise (e.g. Intel SDM 9.1). cpu_is_bsp() is basically reporting the result of the MP init protocol in condensed from. Jan --------------enigFD63D7450029F9AAD0541748 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk23FRoACgkQitSsb3rl5xR0fwCgw/p5sUkZM8sTPvmXbVV01LD/ DbIAn3KtGZ7xwwu9e8VbD/qGkFsP4AX8 =92ZI -----END PGP SIGNATURE----- --------------enigFD63D7450029F9AAD0541748--