From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEyn5-0005rp-Nx for qemu-devel@nongnu.org; Wed, 27 Apr 2011 03:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEyn4-0004hZ-LB for qemu-devel@nongnu.org; Wed, 27 Apr 2011 03:04:03 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:44909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEyn4-0004hN-7h for qemu-devel@nongnu.org; Wed, 27 Apr 2011 03:04:02 -0400 Message-ID: <4DB7BFDC.6050801@web.de> Date: Wed, 27 Apr 2011 09:03:56 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1303887233-6668-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1303887233-6668-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7D37C5B2645A0D8A609B6F53" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] virtio-9p: move 9p files around List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7D37C5B2645A0D8A609B6F53 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-04-27 08:53, Aneesh Kumar K.V wrote: > Now that we start adding more files related to 9pfs > it make sense to move them to a separate directory >=20 > Signed-off-by: Aneesh Kumar K.V > --- > Makefile.objs | 10 +++++++--- > Makefile.target | 6 ++++-- > configure | 2 ++ > {hw =3D> fsdev}/file-op-9p.h | 0 > fsdev/qemu-fsdev.h | 2 +- > hw/{ =3D> 9pfs}/virtio-9p-debug.c | 0 > hw/{ =3D> 9pfs}/virtio-9p-debug.h | 0 > hw/{ =3D> 9pfs}/virtio-9p-local.c | 0 > hw/{ =3D> 9pfs}/virtio-9p-posix-acl.c | 2 +- > hw/{ =3D> 9pfs}/virtio-9p-xattr-user.c | 2 +- > hw/{ =3D> 9pfs}/virtio-9p-xattr.c | 2 +- > hw/{ =3D> 9pfs}/virtio-9p-xattr.h | 0 > hw/{ =3D> 9pfs}/virtio-9p.c | 0 > hw/{ =3D> 9pfs}/virtio-9p.h | 2 +- > 14 files changed, 18 insertions(+), 10 deletions(-) > rename {hw =3D> fsdev}/file-op-9p.h (100%) > rename hw/{ =3D> 9pfs}/virtio-9p-debug.c (100%) > rename hw/{ =3D> 9pfs}/virtio-9p-debug.h (100%) > rename hw/{ =3D> 9pfs}/virtio-9p-local.c (100%) > rename hw/{ =3D> 9pfs}/virtio-9p-posix-acl.c (99%) > rename hw/{ =3D> 9pfs}/virtio-9p-xattr-user.c (98%) > rename hw/{ =3D> 9pfs}/virtio-9p-xattr.c (99%) > rename hw/{ =3D> 9pfs}/virtio-9p-xattr.h (100%) > rename hw/{ =3D> 9pfs}/virtio-9p.c (100%) That's a good chance to split up this file, move virtio_9p_get_config into a separate one and build the large virtio-9p.c as part of hwlib while keeping the new file target-specific. I've some hack for this lying around, but now that you are already at it... Thanks, Jan --------------enig7D37C5B2645A0D8A609B6F53 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk23v98ACgkQitSsb3rl5xTbiACgwJjJh1J0wzuUAa8QI+DvbxPK IegAoOCe7F33dNrgYjIpcm5Nf8GJW4LI =4x3h -----END PGP SIGNATURE----- --------------enig7D37C5B2645A0D8A609B6F53--