From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QF69r-0007T2-UO for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QF69q-0002XZ-T7 for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:56:03 -0400 Received: from goliath.siemens.de ([192.35.17.28]:24301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QF69q-0002XR-Cc for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:56:02 -0400 Message-ID: <4DB82E75.4010005@siemens.com> Date: Wed, 27 Apr 2011 16:55:49 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1303887233-6668-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <4DB7BFDC.6050801@web.de> <874o5kx9uk.fsf@linux.vnet.ibm.com> In-Reply-To: <874o5kx9uk.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-9p: move 9p files around List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 2011-04-27 12:33, Aneesh Kumar K.V wrote: > On Wed, 27 Apr 2011 09:03:56 +0200, Jan Kiszka wrote: >> On 2011-04-27 08:53, Aneesh Kumar K.V wrote: >>> Now that we start adding more files related to 9pfs >>> it make sense to move them to a separate directory >>> >>> Signed-off-by: Aneesh Kumar K.V >>> --- >>> Makefile.objs | 10 +++++++--- >>> Makefile.target | 6 ++++-- >>> configure | 2 ++ >>> {hw => fsdev}/file-op-9p.h | 0 >>> fsdev/qemu-fsdev.h | 2 +- >>> hw/{ => 9pfs}/virtio-9p-debug.c | 0 >>> hw/{ => 9pfs}/virtio-9p-debug.h | 0 >>> hw/{ => 9pfs}/virtio-9p-local.c | 0 >>> hw/{ => 9pfs}/virtio-9p-posix-acl.c | 2 +- >>> hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +- >>> hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +- >>> hw/{ => 9pfs}/virtio-9p-xattr.h | 0 >>> hw/{ => 9pfs}/virtio-9p.c | 0 >>> hw/{ => 9pfs}/virtio-9p.h | 2 +- >>> 14 files changed, 18 insertions(+), 10 deletions(-) >>> rename {hw => fsdev}/file-op-9p.h (100%) >>> rename hw/{ => 9pfs}/virtio-9p-debug.c (100%) >>> rename hw/{ => 9pfs}/virtio-9p-debug.h (100%) >>> rename hw/{ => 9pfs}/virtio-9p-local.c (100%) >>> rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (99%) >>> rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%) >>> rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%) >>> rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%) >>> rename hw/{ => 9pfs}/virtio-9p.c (100%) >> >> That's a good chance to split up this file, move virtio_9p_get_config >> into a separate one and build the large virtio-9p.c as part of hwlib >> while keeping the new file target-specific. I've some hack for this >> lying around, but now that you are already at it... >> > > How about doing the below patch also and move all those device specific > stuff to virtio-9p-device.c and rest in virtio-9p.c ? Looks ok. Removing #ifdefs is generally welcome. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux