From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused
Date: Thu, 28 Apr 2011 14:35:03 +0200 [thread overview]
Message-ID: <4DB95EF7.6090301@redhat.com> (raw)
In-Reply-To: <4DB95AB6.7020107@mail.berlios.de>
On 04/28/2011 02:16 PM, Stefan Weil wrote:
>
> What about using buf instead of packet (no need for extensions, reduces
> code by 4 lines)?
Uh, you're right!... I was assuming some side effect later, but after
the refactoring this is indeed the only place where packet is used in
the function, and it could use buf.
Paolo
next prev parent reply other threads:[~2011-04-28 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 8:07 [Qemu-devel] [PATCH] ide/atapi: fix set but unused Alon Levy
2011-04-28 12:07 ` Paolo Bonzini
2011-04-28 12:16 ` Stefan Weil
2011-04-28 12:35 ` Paolo Bonzini [this message]
2011-04-28 13:34 ` [Qemu-devel] [PATCHv2] " Alon Levy
2011-04-28 14:46 ` Stefan Weil
2011-04-29 10:58 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB95EF7.6090301@redhat.com \
--to=pbonzini@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).