From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QFQR7-0004BS-09
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 08:35:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QFQR6-0007hY-5F
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 08:35:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21042)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QFQR5-0007hL-Pd
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 08:35:12 -0400
Message-ID: <4DB95EF7.6090301@redhat.com>
Date: Thu, 28 Apr 2011 14:35:03 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1303978031-24366-1-git-send-email-alevy@redhat.com>
	<4DB95891.5010300@redhat.com> <4DB95AB6.7020107@mail.berlios.de>
In-Reply-To: <4DB95AB6.7020107@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ide/atapi: fix set but unused
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org

On 04/28/2011 02:16 PM, Stefan Weil wrote:
>
> What about using buf instead of packet (no need for extensions, reduces
> code by 4 lines)?

Uh, you're right!... I was assuming some side effect later, but after 
the refactoring this is indeed the only place where packet is used in 
the function, and it could use buf.

Paolo