From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFQby-0005ST-RL for qemu-devel@nongnu.org; Thu, 28 Apr 2011 08:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFQbx-0000h1-T8 for qemu-devel@nongnu.org; Thu, 28 Apr 2011 08:46:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFQbx-0000gZ-KT for qemu-devel@nongnu.org; Thu, 28 Apr 2011 08:46:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3SCkNde021201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Apr 2011 08:46:23 -0400 Message-ID: <4DB96173.9020405@redhat.com> Date: Thu, 28 Apr 2011 14:45:39 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1303136821-13333-1-git-send-email-Jes.Sorensen@redhat.com> <1303136821-13333-2-git-send-email-Jes.Sorensen@redhat.com> <20110427120520.74e348d9@doriath> <4DB830D2.7010706@redhat.com> In-Reply-To: <4DB830D2.7010706@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Markus Armbruster On 04/27/11 17:05, Jes Sorensen wrote: > On 04/27/11 17:05, Luiz Capitulino wrote: >> On Mon, 18 Apr 2011 16:27:01 +0200 >> Jes.Sorensen@redhat.com wrote: >> >>> From: Jes Sorensen >>> >>> This is quivalent to snapshot_blkdev in the human monitor, with _sync >>> added to the command name to make it explicit that the command is >>> synchronous and leave space for a future async version. >> >> I'm not sure appending "_sync" is such a good convention, most commands >> are sync today and they don't have it. I'd prefer to call it snapshot_blkdev >> and note in the documentation how it works. >> >> On the other hand, I'm not sure how Anthony is going to model async >> commands, so maybe he has a better suggestion. > > The _sync prefix is on purpose to leave space for a possible async > implementation of the snapshot command in the future. This isn't related > to it being a sync vs async qmp command though. If people are more comfortable with the QMP command being "blockdev-snapshot" and then using {-,_}async for the async comment in the monitor and QMP later, that is fine with me. I'd just like to move on this and get it upstream. Cheers, Jes