From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFR3v-0001qd-6o for qemu-devel@nongnu.org; Thu, 28 Apr 2011 09:15:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFR3q-0004nD-IJ for qemu-devel@nongnu.org; Thu, 28 Apr 2011 09:15:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFR3q-0004n0-4V for qemu-devel@nongnu.org; Thu, 28 Apr 2011 09:15:14 -0400 Message-ID: <4DB96832.7090704@redhat.com> Date: Thu, 28 Apr 2011 15:14:26 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1303136821-13333-1-git-send-email-Jes.Sorensen@redhat.com> <1303136821-13333-2-git-send-email-Jes.Sorensen@redhat.com> <20110427120520.74e348d9@doriath> In-Reply-To: <20110427120520.74e348d9@doriath> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Markus Armbruster On 04/27/11 17:05, Luiz Capitulino wrote: >> > +Synchronous snapshot of block device, using snapshot file as target >> > +if provided. > It's not optional in HMP: > > (qemu) snapshot_blkdev ide0-hd0 > Parameter 'snapshot_file' is missing > (qemu) > The parameter is optional in HMP, however it will fail if there is no snapshot filename or there is no flag for internal snapshots (which is currently unsupported). Jes