From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFRRA-0007Kw-S3 for qemu-devel@nongnu.org; Thu, 28 Apr 2011 09:39:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFRR9-0008GL-TC for qemu-devel@nongnu.org; Thu, 28 Apr 2011 09:39:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFRR9-0008FL-ER for qemu-devel@nongnu.org; Thu, 28 Apr 2011 09:39:19 -0400 Message-ID: <4DB96E9E.6020300@redhat.com> Date: Thu, 28 Apr 2011 15:41:50 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1303136821-13333-1-git-send-email-Jes.Sorensen@redhat.com> <1303136821-13333-2-git-send-email-Jes.Sorensen@redhat.com> <20110427120520.74e348d9@doriath> <4DB969E5.2060501@redhat.com> In-Reply-To: <4DB969E5.2060501@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino Am 28.04.2011 15:21, schrieb Jes Sorensen: > On 04/27/11 17:05, Luiz Capitulino wrote: >>> +If a new image file is specified, the new image file will become the >>>> +new root image. If format is specified, the snapshot file will be >>>> +created in that format. Otherwise the snapshot will be internal! >>>> +(currently unsupported). >> Sorry for the stupid question, but what's a "new root image"? Also, all >> these assumptions seem human features to me, as it can save some typing >> and I can poke around to see where the snapshots are stored. >> >> All arguments should be mandatory in QMP, IMO. > > Sorry, but there is absolutely no reason to make all arguments > mandatory. Sure it can be done, but the only result is a separate > handling function for it, so we got more almost identical, but still > different code to maintain. > >> Finally, what's the expect behavior when -snapshot is used? I'm getting >> this: >> >> (qemu) snapshot_blkdev ide0-hd0 snap-test >> Could not open '/tmp/vl.6w8YXA' >> (qemu) > > What type of file system is your /tmp? You need to provide full path to > the snapshot file if you don't want it created next to where your qemu > binary is being executed. I think the problem is that this is a temporary file, i.e. unlinked directly after it has been opened. Trying to reopen a deleted file is a bad idea. Kevin