From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QFSUc-0000I3-St
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 10:46:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QFSUb-0001Gp-Qk
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 10:46:58 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:51397)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QFSUb-0001Ge-CJ
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 10:46:57 -0400
Message-ID: <4DB97DDD.2010908@mail.berlios.de>
Date: Thu, 28 Apr 2011 16:46:53 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <4DB95EF7.6090301@redhat.com>
	<1303997679-8885-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1303997679-8885-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] ide/atapi: fix set but unused
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

Am 28.04.2011 15:34, schrieb Alon Levy:
> Signed-off-by: Alon Levy<alevy@redhat.com>
> ---
>   hw/ide/atapi.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 690a0ab..0073c8d 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -1080,17 +1080,15 @@ static const struct {
>
>   void ide_atapi_cmd(IDEState *s)
>   {
> -    const uint8_t *packet;
>       uint8_t *buf;
>
> -    packet = s->io_buffer;
>       buf = s->io_buffer;
>   #ifdef DEBUG_IDE_ATAPI
>       {
>           int i;
>           printf("ATAPI limit=0x%x packet:", s->lcyl | (s->hcyl<<  8));
>           for(i = 0; i<  ATAPI_PACKET_SIZE; i++) {
> -            printf(" %02x", packet[i]);
> +            printf(" %02x", buf[i]);
>           }
>           printf("\n");
>       }
>    

Acked-by: Stefan Weil <weil@mail.berlios.de>