From: Stefan Weil <weil@mail.berlios.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Weil <Stefan.Weil@Kath-Kirche-Ladenburg.de>,
Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements)
Date: Thu, 28 Apr 2011 19:44:47 +0200 [thread overview]
Message-ID: <4DB9A78F.3000006@mail.berlios.de> (raw)
In-Reply-To: <4DB9A644.6000802@codemonkey.ws>
Am 28.04.2011 19:39, schrieb Anthony Liguori:
> On 04/28/2011 12:08 PM, Stefan Weil wrote:
>> From: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>>
>> Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files
>> without fixing the include paths.
>>
>> Signed-off-by: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>
>
> This is not correct. I think we learned in IRC that the problem is
> Stefan is using CFLAGS=-g which overrides the CFLAGS append added by
> this patch.
>
> Regards,
>
> Anthony Liguori
QEMU Makefiles use QEMU_CFLAGS - setting CFLAGS in Makefile* is wrong,
because now users can no longer set their own CFLAGS.
The special CFLAGS for virtio should be removed (with my patch applied
first).
The second best solution would be changing CFLAGS to QEMU_CFLAGS in
Makefile.objs and Makefile.target.
Regards,
Stefan
next prev parent reply other threads:[~2011-04-28 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 17:08 [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include statements) Stefan Weil
2011-04-28 17:39 ` Anthony Liguori
2011-04-28 17:44 ` Stefan Weil [this message]
2011-04-28 17:46 ` Anthony Liguori
2011-04-28 19:04 ` Blue Swirl
2011-04-28 20:02 ` [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw Stefan Weil
2011-04-28 20:49 ` Anthony Liguori
2011-04-28 21:44 ` Stefan Weil
2011-04-29 0:46 ` Peter Maydell
2011-05-27 18:27 ` Stefan Weil
2011-05-28 16:51 ` Aneesh Kumar K.V
2011-05-28 19:12 ` Venkateswararao Jujjuri
2011-04-28 18:21 ` [Qemu-devel] [PATCH v2] " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB9A78F.3000006@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=Stefan.Weil@Kath-Kirche-Ladenburg.de \
--cc=aliguori@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).