From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35987)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QFVGo-00026Y-Rt
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:44:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QFVGn-0005Sr-Vv
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:44:54 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:57800)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QFVGn-0005Sk-JL
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:44:53 -0400
Message-ID: <4DB9A78F.3000006@mail.berlios.de>
Date: Thu, 28 Apr 2011 19:44:47 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1304010495-18136-1-git-send-email-weil@mail.berlios.de>
	<4DB9A644.6000802@codemonkey.ws>
In-Reply-To: <4DB9A644.6000802@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include
 statements)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Weil <Stefan.Weil@Kath-Kirche-Ladenburg.de>, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>

Am 28.04.2011 19:39, schrieb Anthony Liguori:
> On 04/28/2011 12:08 PM, Stefan Weil wrote:
>> From: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>>
>> Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files
>> without fixing the include paths.
>>
>> Signed-off-by: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>
>
> This is not correct.   I think we learned in IRC that the problem is 
> Stefan is using CFLAGS=-g which overrides the CFLAGS append added by 
> this patch.
>
> Regards,
>
> Anthony Liguori


QEMU Makefiles use QEMU_CFLAGS - setting CFLAGS in Makefile* is wrong,
because now users can no longer set their own CFLAGS.

The special CFLAGS for virtio should be removed (with my patch applied 
first).
The second best solution would be changing CFLAGS to QEMU_CFLAGS in
Makefile.objs and Makefile.target.

Regards,

Stefan