From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QFVI4-000301-KT
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:46:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QFVI3-0005pQ-RX
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:46:12 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:45484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QFVI3-0005pI-OW
	for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:46:11 -0400
Received: by ywl41 with SMTP id 41so1271947ywl.4
	for <qemu-devel@nongnu.org>; Thu, 28 Apr 2011 10:46:11 -0700 (PDT)
Message-ID: <4DB9A7E0.7080002@codemonkey.ws>
Date: Thu, 28 Apr 2011 12:46:08 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1304010495-18136-1-git-send-email-weil@mail.berlios.de>	<4DB9A644.6000802@codemonkey.ws>
	<4DB9A78F.3000006@mail.berlios.de>
In-Reply-To: <4DB9A78F.3000006@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix compilation (wrong include
 statements)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Weil <Stefan.Weil@Kath-Kirche-Ladenburg.de>

On 04/28/2011 12:44 PM, Stefan Weil wrote:
> Am 28.04.2011 19:39, schrieb Anthony Liguori:
>> On 04/28/2011 12:08 PM, Stefan Weil wrote:
>>> From: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>>>
>>> Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files
>>> without fixing the include paths.
>>>
>>> Signed-off-by: Stefan Weil<Stefan.Weil@Kath-Kirche-Ladenburg.de>
>>
>>
>> This is not correct. I think we learned in IRC that the problem is
>> Stefan is using CFLAGS=-g which overrides the CFLAGS append added by
>> this patch.
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> QEMU Makefiles use QEMU_CFLAGS - setting CFLAGS in Makefile* is wrong,
> because now users can no longer set their own CFLAGS.

Use ./configure --extra-cflags="-g"

Regards,

Anthony Liguori


> The special CFLAGS for virtio should be removed (with my patch applied
> first).
> The second best solution would be changing CFLAGS to QEMU_CFLAGS in
> Makefile.objs and Makefile.target.
>
> Regards,
>
> Stefan
>
>