From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFVI9-00038S-Q1 for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFVI8-0005qh-Oc for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:46:17 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:44366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFVI8-0005qW-Lm for qemu-devel@nongnu.org; Thu, 28 Apr 2011 13:46:16 -0400 Received: by gwb19 with SMTP id 19so1266789gwb.4 for ; Thu, 28 Apr 2011 10:46:16 -0700 (PDT) Message-ID: <4DB9A7E6.40109@codemonkey.ws> Date: Thu, 28 Apr 2011 12:46:14 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4DB84170.4010208@linux.vnet.ibm.com> In-Reply-To: <4DB84170.4010208@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] Request for Pull List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Venkateswararao Jujjuri Cc: qemu-devel@nongnu.org On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: > The following changes since commit > 661bfc80e876d32da8befe53ba0234d87fc0bcc2: > Jan Kiszka (1): > pflash: Restore & fix lazy ROMD switching > > are available in the git repository at: > > git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony It's pretty clear this pull request was done without doing a full build before hand. I don't mean to single you out JV, but this happens too frequently with pull requests so let me be clear about this. If you send me a pull request, you must do a FULL build before hand. That means not specifying a '--target-list' parameter. Regards, Anthony Liguori > > Aneesh Kumar K.V (3): > virtio-9p: move 9p files around > virtio-9p: Print the pdu details on return > virtio-9p: removexattr on default acl should return 0 > > Harsh Prateek Bora (2): > hw/virtio-9p-local.c: Remove unnecessary null char in symlink file > v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0. > > M. Mohan Kumar (1): > virtio-9p: Bugfix to send correct iounit > > Stefan Hajnoczi (1): > vl.c: Replace -virtfs string manipulation with QemuOpts > > Makefile.objs | 10 ++++-- > Makefile.target | 6 ++- > configure | 2 + > {hw => fsdev}/file-op-9p.h | 0 > fsdev/qemu-fsdev.h | 2 +- > hw/{ => 9pfs}/virtio-9p-debug.c | 0 > hw/{ => 9pfs}/virtio-9p-debug.h | 0 > hw/{ => 9pfs}/virtio-9p-local.c | 2 +- > hw/{ => 9pfs}/virtio-9p-posix-acl.c | 17 ++++++++-- > hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +- > hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +- > hw/{ => 9pfs}/virtio-9p-xattr.h | 0 > hw/{ => 9pfs}/virtio-9p.c | 14 ++++++-- > hw/{ => 9pfs}/virtio-9p.h | 4 +- > vl.c | 56 +++++++++++---------------------- > 15 files changed, 62 insertions(+), 55 deletions(-) > rename {hw => fsdev}/file-op-9p.h (100%) > rename hw/{ => 9pfs}/virtio-9p-debug.c (100%) > rename hw/{ => 9pfs}/virtio-9p-debug.h (100%) > rename hw/{ => 9pfs}/virtio-9p-local.c (99%) > rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (88%) > rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%) > rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%) > rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%) > rename hw/{ => 9pfs}/virtio-9p.c (99%) > rename hw/{ => 9pfs}/virtio-9p.h (99%) > >