From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 1/4] qxl: interface_get_command: fix reported mode
Date: Fri, 29 Apr 2011 14:01:16 +0200 [thread overview]
Message-ID: <4DBAA88C.6070702@redhat.com> (raw)
In-Reply-To: <1303979358-4421-2-git-send-email-alevy@redhat.com>
> +static const char *qxl_mode_to_string(int mode)
> +{
> + switch (mode) {
> + case QXL_MODE_COMPAT:
> + return "compat";
> + case QXL_MODE_NATIVE:
> + return "native";
> + case QXL_MODE_UNDEFINED:
> + return "undefined";
> + case QXL_MODE_VGA:
> + return "vga";
> + }
> + return "unknown";
Make that "INVALID"? There never ever should be another move value ...
cheers,
Gerd
next prev parent reply other threads:[~2011-04-29 12:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 8:29 [Qemu-devel] [PATCHv2 0/4] qxl: debug related fixes Alon Levy
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 1/4] qxl: interface_get_command: fix reported mode Alon Levy
2011-04-29 12:01 ` Gerd Hoffmann [this message]
2011-04-29 21:53 ` Alon Levy
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 2/4] qxl: add mode to debugprint on destroy primary Alon Levy
2011-04-29 12:01 ` Gerd Hoffmann
2011-04-29 21:54 ` Alon Levy
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs Alon Levy
2011-04-29 12:09 ` Gerd Hoffmann
2011-04-29 22:19 ` Alon Levy
2011-05-02 9:02 ` [Qemu-devel] debug logging (was: Re: [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs) Gerd Hoffmann
2011-05-02 10:12 ` Alon Levy
2011-05-02 10:25 ` [Qemu-devel] debug logging Gerd Hoffmann
2011-05-02 10:33 ` Alon Levy
2011-05-02 10:37 ` Jan Kiszka
2011-05-02 11:00 ` Markus Armbruster
2011-05-02 11:50 ` Alon Levy
2011-05-02 12:43 ` Jan Kiszka
2011-05-02 13:04 ` Alon Levy
2011-05-02 14:09 ` Paolo Bonzini
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 4/4] qxl: allow QXL_IO_LOG also in vga Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBAA88C.6070702@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).