From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50704)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1QGbMY-00060g-KH
	for qemu-devel@nongnu.org; Sun, 01 May 2011 14:27:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1QGbMX-0001Kx-AF
	for qemu-devel@nongnu.org; Sun, 01 May 2011 14:27:22 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:42295)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1QGbMW-0001Kp-Pi
	for qemu-devel@nongnu.org; Sun, 01 May 2011 14:27:21 -0400
Message-ID: <4DBDA5EA.7070708@web.de>
Date: Sun, 01 May 2011 20:26:50 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <4DBD7D0C.4050106@web.de>
In-Reply-To: <4DBD7D0C.4050106@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Sender: andreas.faerber@web.de
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Build breakage on OpenSolaris - softfloat
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Andreas F=E4rber schrieb:
> CC    i386-softmmu/op_helper.o
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:110: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:110: error:=20
> (near initialization for `f15rk[0]')
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:111: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:111: error:=20
> (near initialization for `f15rk[1]')
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:112: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:112: error:=20
> (near initialization for `f15rk[2]')
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:113: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:113: error:=20
> (near initialization for `f15rk[3]')
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:114: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:114: error:=20
> (near initialization for `f15rk[4]')
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:115: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:115: error:=20
> (near initialization for `f15rk[5]')
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:116: error:=20
> initializer element is not constant
> /export/home/andreas/QEMU/qemu/target-i386/op_helper.c:116: error:=20
> (near initialization for `f15rk[6]')
> gmake[1]: *** [op_helper.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
> Looks like an issue with make_floatx80().
As suggested by Peter, I inspected the op_helper.c preprocessor output:

# 108 "/export/home/andreas/QEMU/qemu/target-i386/op_helper.c"
static const CPU86_LDouble f15rk[7] =3D
{
    ((floatx80) { 0x0000000000000000LL, 0x0000 }),
    ((floatx80) { 0x8000000000000000LL, 0x3fff }),
    ((floatx80) { 0xc90fdaa22168c235LL, 0x4000 }),
    ((floatx80) { 0x9a209a84fbcff799LL, 0x3ffd }),
    ((floatx80) { 0xb17217f7d1cf79acLL, 0x3ffe }),
    ((floatx80) { 0xb8aa3b295c17f0bcLL, 0x3fff }),
    ((floatx80) { 0xd49a784bcd1b8afeLL, 0x4000 }),
};

Doesn't look unexpected.

typedef floatx80 CPU86_LDouble;

and

# 153 "/export/home/andreas/QEMU/qemu/fpu/softfloat.h"
typedef struct {
    uint64_t low;
    uint16_t high;
} floatx80;

look okay, too.

Andreas