From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] debug logging
Date: Mon, 02 May 2011 12:25:30 +0200 [thread overview]
Message-ID: <4DBE869A.4010403@redhat.com> (raw)
In-Reply-To: <20110502101200.GG17629@playa.redhat.com>
Hi,
> dbg_print takes care of making it standard to have a loglevel and prefix, sounds
> good, but I'd still like to know if it is acceptable to also redirect with -debug,
> I guess reusing the DeviceState then, instead of my added struct, so just letting
> DeviceState.debug_chardev == NULL by default, and settable with
> -debug<devname>,id=<chardev_id>
Making dbg_print use DeviceState.debug_chardev (if present, stderr
otherwise) looks sane to me. Buf I'd use standard properties then to
set it instead of a separate -debug switch, i.e.
-chardev file,id=messages,path=... \
-device foo,dbg=1,dbglog=messages
cheers,
Gerd
next prev parent reply other threads:[~2011-05-02 10:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 8:29 [Qemu-devel] [PATCHv2 0/4] qxl: debug related fixes Alon Levy
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 1/4] qxl: interface_get_command: fix reported mode Alon Levy
2011-04-29 12:01 ` Gerd Hoffmann
2011-04-29 21:53 ` Alon Levy
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 2/4] qxl: add mode to debugprint on destroy primary Alon Levy
2011-04-29 12:01 ` Gerd Hoffmann
2011-04-29 21:54 ` Alon Levy
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs Alon Levy
2011-04-29 12:09 ` Gerd Hoffmann
2011-04-29 22:19 ` Alon Levy
2011-05-02 9:02 ` [Qemu-devel] debug logging (was: Re: [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs) Gerd Hoffmann
2011-05-02 10:12 ` Alon Levy
2011-05-02 10:25 ` Gerd Hoffmann [this message]
2011-05-02 10:33 ` [Qemu-devel] debug logging Alon Levy
2011-05-02 10:37 ` Jan Kiszka
2011-05-02 11:00 ` Markus Armbruster
2011-05-02 11:50 ` Alon Levy
2011-05-02 12:43 ` Jan Kiszka
2011-05-02 13:04 ` Alon Levy
2011-05-02 14:09 ` Paolo Bonzini
2011-04-28 8:29 ` [Qemu-devel] [PATCHv2 4/4] qxl: allow QXL_IO_LOG also in vga Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBE869A.4010403@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).