From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGvTB-0006hn-Co for qemu-devel@nongnu.org; Mon, 02 May 2011 11:55:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QGvT6-00087Z-4g for qemu-devel@nongnu.org; Mon, 02 May 2011 11:55:33 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:40271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGvT5-00087G-SP for qemu-devel@nongnu.org; Mon, 02 May 2011 11:55:28 -0400 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e38.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p428MAJg001912 for ; Mon, 2 May 2011 02:22:10 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p42FtFOW161548 for ; Mon, 2 May 2011 09:55:17 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p42Fsj8P021597 for ; Mon, 2 May 2011 09:54:47 -0600 Message-ID: <4DBED3DE.8030306@linux.vnet.ibm.com> Date: Mon, 02 May 2011 08:55:10 -0700 From: Venkateswararao Jujjuri MIME-Version: 1.0 References: <4DB84170.4010208@linux.vnet.ibm.com> <4DB9A7E6.40109@codemonkey.ws> In-Reply-To: <4DB9A7E6.40109@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] Request for Pull List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 04/28/2011 10:46 AM, Anthony Liguori wrote: > On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: >> The following changes since commit >> 661bfc80e876d32da8befe53ba0234d87fc0bcc2: >> Jan Kiszka (1): >> pflash: Restore & fix lazy ROMD switching >> >> are available in the git repository at: >> >> git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony > > It's pretty clear this pull request was done without doing a full > build before hand. > > I don't mean to single you out JV, but this happens too frequently > with pull requests so let me be clear about this. > > If you send me a pull request, you must do a FULL build before hand. > That means not specifying a '--target-list' parameter. I ran and tested for x86. I am unaware of this. From now on, I will make sure not to specify ' target-list ' for the PULL validation build. Regards, JV > > Regards, > > Anthony Liguori > >> >> Aneesh Kumar K.V (3): >> virtio-9p: move 9p files around >> virtio-9p: Print the pdu details on return >> virtio-9p: removexattr on default acl should return 0 >> >> Harsh Prateek Bora (2): >> hw/virtio-9p-local.c: Remove unnecessary null char in symlink file >> v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0. >> >> M. Mohan Kumar (1): >> virtio-9p: Bugfix to send correct iounit >> >> Stefan Hajnoczi (1): >> vl.c: Replace -virtfs string manipulation with QemuOpts >> >> Makefile.objs | 10 ++++-- >> Makefile.target | 6 ++- >> configure | 2 + >> {hw => fsdev}/file-op-9p.h | 0 >> fsdev/qemu-fsdev.h | 2 +- >> hw/{ => 9pfs}/virtio-9p-debug.c | 0 >> hw/{ => 9pfs}/virtio-9p-debug.h | 0 >> hw/{ => 9pfs}/virtio-9p-local.c | 2 +- >> hw/{ => 9pfs}/virtio-9p-posix-acl.c | 17 ++++++++-- >> hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +- >> hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +- >> hw/{ => 9pfs}/virtio-9p-xattr.h | 0 >> hw/{ => 9pfs}/virtio-9p.c | 14 ++++++-- >> hw/{ => 9pfs}/virtio-9p.h | 4 +- >> vl.c | 56 +++++++++++---------------------- >> 15 files changed, 62 insertions(+), 55 deletions(-) >> rename {hw => fsdev}/file-op-9p.h (100%) >> rename hw/{ => 9pfs}/virtio-9p-debug.c (100%) >> rename hw/{ => 9pfs}/virtio-9p-debug.h (100%) >> rename hw/{ => 9pfs}/virtio-9p-local.c (99%) >> rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (88%) >> rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%) >> rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%) >> rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%) >> rename hw/{ => 9pfs}/virtio-9p.c (99%) >> rename hw/{ => 9pfs}/virtio-9p.h (99%) >> >> >