From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QHFLM-0006HT-TR
	for qemu-devel@nongnu.org; Tue, 03 May 2011 09:08:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QHFLM-0001tA-55
	for qemu-devel@nongnu.org; Tue, 03 May 2011 09:08:48 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:44648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QHFLL-0001t6-Ul
	for qemu-devel@nongnu.org; Tue, 03 May 2011 09:08:48 -0400
Received: by gxk26 with SMTP id 26so19335gxk.4
	for <qemu-devel@nongnu.org>; Tue, 03 May 2011 06:08:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4DBFFE5B.6040200@redhat.com>
Date: Tue, 03 May 2011 15:08:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20110503120616.GA10133@lst.de> <20110503120651.GC10206@lst.de>
In-Reply-To: <20110503120651.GC10206@lst.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] ide: add TRIM support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

On 05/03/2011 02:06 PM, Christoph Hellwig wrote:
> +    case IDE_DMA_TRIM:
> +        m->aiocb = dma_bdrv_io(s->bs,&s->sg, sector_num,
> +                               ide_issue_trim,, pmac_ide_transfer_cb, s, 1);
> +        break;

Not compile-tested?

Paolo