From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39181)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QHJ5t-0006rw-El
	for qemu-devel@nongnu.org; Tue, 03 May 2011 13:09:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QHJ5s-0003yh-FE
	for qemu-devel@nongnu.org; Tue, 03 May 2011 13:09:05 -0400
Received: from thoth.sbs.de ([192.35.17.2]:22156)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1QHJ5s-0003yX-6u
	for qemu-devel@nongnu.org; Tue, 03 May 2011 13:09:04 -0400
Message-ID: <4DC036AD.7070306@siemens.com>
Date: Tue, 03 May 2011 19:09:01 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4DC00BB1.7000008@siemens.com> <4DC031CC.1040902@siemens.com>
	<4DC0336B.7020106@redhat.com>
In-Reply-To: <4DC0336B.7020106@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, Alexander Graf <agraf@suse.de>

On 2011-05-03 18:55, Avi Kivity wrote:
> On 05/03/2011 07:48 PM, Jan Kiszka wrote:
>> This helps reducing our build-time checks for feature support in the
>> available Linux kernel headers. And it helps users that do not have
>> sufficiently recent headers installed on their build machine.
>>
>> Header upstate is triggered via
>>
>>      scripts/update-linux-headers.sh LINUX_PATH
>>
>> from the top-level QEMU source directory.
>>
>> Consequently, the patch removes and build-time checks for kvm and vhost
>> in configure, and also the --kerneldir switch. Kernel headers are
>> supposed to be provided by QEMU only.
>>
>> Kernel headers were automatically imported from current kvm.git,
>> 93c016c8c4. Some are not covered by any license and can be considered
>> GPLv2 with user space exception. Some are explicitly GPLv2 - at least
>> for QEMU that's fine in any case. Others are "BSD" which shall to be
>> considered a compatible variant according to Rusty.
> 
> Reluctant ack.

What downsides do you see?

> 
> (though for commit log cleanliness, the scripts and the headers should 
> be in separate commits)
> 

I'll split up in thread parts: script, headers, build system changes.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux