From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] s390x kvm and smp
Date: Wed, 04 May 2011 12:43:48 +0200 [thread overview]
Message-ID: <4DC12DE4.80702@de.ibm.com> (raw)
Alex,
I have trouble getting kvm smp support running. Turns out that qemu does a kvm
run even on secondary CPUs which dont have a sane state (initial psw == 0)
triggering some program faults. Architecturally these cpus are in the stopped
state, so we should not do KVM_RUN. (these CPUs will be started by a SIGP
restart later during the boot process)
This patch seems to help (it allows me to boot and use more than 1 cpu)
--- a/cpus.c
+++ b/cpus.c
@@ -131,6 +131,10 @@ static void do_vm_stop(int reason)
static int cpu_can_run(CPUState *env)
{
+ if (env->halted) {
+ return 0;
+ }
+
if (env->stop) {
return 0;
}
but it does not look like the right solution. What are the proper
definitions for halted and stopped?
Christian
next reply other threads:[~2011-05-04 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 10:43 Christian Borntraeger [this message]
2011-05-04 10:59 ` [Qemu-devel] s390x kvm and smp Jan Kiszka
2011-05-04 16:13 ` Christian Borntraeger
2011-05-04 17:11 ` Alexander Graf
2011-05-05 7:29 ` [Qemu-devel] [PATCH] s390x: fix smp support for kvm Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC12DE4.80702@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cotte@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).