From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:32843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QHeGl-0006Q0-7b
	for qemu-devel@nongnu.org; Wed, 04 May 2011 11:45:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QHeGk-00086e-Ks
	for qemu-devel@nongnu.org; Wed, 04 May 2011 11:45:43 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:35170)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QHeGk-00086T-GL
	for qemu-devel@nongnu.org; Wed, 04 May 2011 11:45:42 -0400
Received: by pzk30 with SMTP id 30so681525pzk.4
	for <qemu-devel@nongnu.org>; Wed, 04 May 2011 08:45:41 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DC1749A.2050805@twiddle.net>
Date: Wed, 04 May 2011 08:45:30 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1304470768-16924-1-git-send-email-jcmvbkbc@gmail.com>
	<1304470768-16924-8-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1304470768-16924-8-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 08/28] target-xtensa: implement conditional
 jumps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

On 05/03/2011 05:59 PM, Max Filippov wrote:
> +                int label = gen_new_label();
> +                int inv = BRI12_M & 1;
> +
> +                switch (BRI12_M & 2) {
> +                case 0: /*BEQZ*/
> +                    tcg_gen_brcondi_i32(inv ? TCG_COND_EQ : TCG_COND_NE,
> +                            cpu_R[BRI12_S], 0, label);
> +                    break;
> +
> +                case 2: /*BLTZ*/
> +                    tcg_gen_brcondi_i32(inv ? TCG_COND_LT : TCG_COND_GE,
> +                            cpu_R[BRI12_S], 0, label);
> +                    break;
> +                }
> +                gen_jumpi(dc, dc->pc + 4 + BRI12_IMM12_SE);
> +                gen_set_label(label);
> +                gen_jumpi(dc, dc->pc + 3);

It seems to me that this code could be cleaned up by extracting
the branching and jumpi'ing into a function.  There's a lot of
repetition here.

Also, once you do get around to using chained TB's, there'll be
only one place to have to update to get that to happen.


r~