From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QHeMd-00031k-76
	for qemu-devel@nongnu.org; Wed, 04 May 2011 11:51:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QHeMc-0000jy-E7
	for qemu-devel@nongnu.org; Wed, 04 May 2011 11:51:47 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:50183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QHeMc-0000jr-8x
	for qemu-devel@nongnu.org; Wed, 04 May 2011 11:51:46 -0400
Received: by pvg3 with SMTP id 3so681113pvg.4
	for <qemu-devel@nongnu.org>; Wed, 04 May 2011 08:51:45 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4DC17607.7060900@twiddle.net>
Date: Wed, 04 May 2011 08:51:35 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1304470768-16924-1-git-send-email-jcmvbkbc@gmail.com>
	<1304470768-16924-11-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1304470768-16924-11-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 11/28] target-xtensa: implement RST3 group
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

On 05/03/2011 05:59 PM, Max Filippov wrote:
> +            case 2: /*SEXTu*/
> +                HAS_OPTION(XTENSA_OPTION_MISC_OP);
> +                {
> +                    TCGv_i32 tmp = tcg_temp_new_i32();
> +                    tcg_gen_shli_i32(tmp, cpu_R[RRR_S], 24 - RRR_T);
> +                    tcg_gen_sari_i32(cpu_R[RRR_R], tmp, 24 - RRR_T);
> +                    tcg_temp_free(tmp);

It's probably worth special-casing extensions from bit 7 and 15
as normal 8 and 16-bit sign-extensions.  Those are likely to be
99% of all extension operations actually performed.


r~