From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52395)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QHxJF-0005gt-2L
	for qemu-devel@nongnu.org; Thu, 05 May 2011 08:05:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QHxJE-0007Ob-2c
	for qemu-devel@nongnu.org; Thu, 05 May 2011 08:05:33 -0400
Message-ID: <4DC29287.5030106@redhat.com>
Date: Thu, 05 May 2011 14:05:27 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <BANLkTik3hmvH6_tUuEZjR8j0L04PdCk7mw@mail.gmail.com>
In-Reply-To: <BANLkTik3hmvH6_tUuEZjR8j0L04PdCk7mw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response
 patch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Vesely <jano.vesely@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

> diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
> index 346db3e..a51d89b 100644
> --- a/hw/usb-uhci.c
> +++ b/hw/usb-uhci.c
> @@ -732,11 +732,21 @@ out:
>       case USB_RET_STALL:
>           td->ctrl |= TD_CTRL_STALL;
>           td->ctrl&= ~TD_CTRL_ACTIVE;
> +        s->status |= UHCI_STS_USBERR;

Just this line should be enougth.

>       case USB_RET_BABBLE:
>           td->ctrl |= TD_CTRL_BABBLE | TD_CTRL_STALL;
>           td->ctrl&= ~TD_CTRL_ACTIVE;
> +        s->status |= UHCI_STS_USBERR;

Likewise.

Tried that?

cheers,
   Gerd