From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, armbru@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup
Date: Thu, 05 May 2011 16:30:57 +0200 [thread overview]
Message-ID: <4DC2B4A1.6030204@redhat.com> (raw)
In-Reply-To: <1304605266.3081.5.camel@x201>
On 05/05/11 16:21, Alex Williamson wrote:
>> > A bit worried that ram_addr_t size might thinkably overflow
>> > (it's just a long, could be a 4G ram). Break it out when it fills up?
> struct CPUPhysMemoryClient {
> void (*set_memory)(struct CPUPhysMemoryClient *client,
> target_phys_addr_t start_addr,
> ram_addr_t size,
> ram_addr_t phys_offset);
>
> ram_addr_t seems to be the standard for describing these types of
> things. It's an unsigned long, so 4G is only concern for 32b builds,
> which don't support that much memory anyway. Please apply. Thanks,
A memory size can obviously not be bigger than the maximum physical
address, so I find it really hard to see how this could overflow.
It seems fair to use it for the size here.
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
next prev parent reply other threads:[~2011-05-05 14:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 18:36 [Qemu-devel] [PATCH v2 0/3] CPUPhysMemoryClient: Fixes and batching Alex Williamson
2011-05-03 18:36 ` [Qemu-devel] [PATCH v2 1/3] CPUPhysMemoryClient: Fix typo in phys memory client registration Alex Williamson
2011-05-03 18:36 ` [Qemu-devel] [PATCH v2 2/3] CPUPhysMemoryClient: Pass guest physical address not region offset Alex Williamson
2011-05-03 18:36 ` [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup Alex Williamson
2011-05-05 13:21 ` Michael S. Tsirkin
2011-05-05 14:21 ` Alex Williamson
2011-05-05 14:30 ` Jes Sorensen [this message]
2011-05-05 15:18 ` Michael S. Tsirkin
2011-05-05 15:36 ` Jes Sorensen
2011-05-05 15:38 ` Michael S. Tsirkin
2011-05-05 15:40 ` Jes Sorensen
2011-05-05 15:41 ` Michael S. Tsirkin
2011-05-05 15:21 ` Michael S. Tsirkin
2011-05-25 3:47 ` Alex Williamson
2011-05-25 6:08 ` Michael S. Tsirkin
2011-05-05 13:21 ` [Qemu-devel] [PATCH v2 0/3] CPUPhysMemoryClient: Fixes and batching Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2B4A1.6030204@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).