From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QI0bv-00041B-N7 for qemu-devel@nongnu.org; Thu, 05 May 2011 11:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QI0bu-0008Ax-OP for qemu-devel@nongnu.org; Thu, 05 May 2011 11:37:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QI0bu-0008Ap-Fv for qemu-devel@nongnu.org; Thu, 05 May 2011 11:37:02 -0400 Message-ID: <4DC2C3E4.8020509@redhat.com> Date: Thu, 05 May 2011 17:36:04 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <20110503182039.28430.26530.stgit@s20.home> <20110503183652.28430.83897.stgit@s20.home> <20110505132106.GG30119@redhat.com> <1304605266.3081.5.camel@x201> <4DC2B4A1.6030204@redhat.com> <20110505151859.GA1915@redhat.com> In-Reply-To: <20110505151859.GA1915@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jan.kiszka@siemens.com, Alex Williamson , qemu-devel@nongnu.org, armbru@redhat.com On 05/05/11 17:18, Michael S. Tsirkin wrote: >> > A memory size can obviously not be bigger than the maximum physical >> > address, so I find it really hard to see how this could overflow. > For example, a 4G size does not fit in 32 bits. That is the only corner case - you can handle that by -1 if you like. Jes