From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QI1HP-0000QN-GC
	for qemu-devel@nongnu.org; Thu, 05 May 2011 12:19:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QI1HN-0002XM-Jm
	for qemu-devel@nongnu.org; Thu, 05 May 2011 12:19:55 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:65426)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QI1HN-0002VT-78
	for qemu-devel@nongnu.org; Thu, 05 May 2011 12:19:53 -0400
Message-ID: <4DC2CE24.40205@mail.berlios.de>
Date: Thu, 05 May 2011 18:19:48 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1304196013-14432-1-git-send-email-weil@mail.berlios.de>
	<1304196013-14432-5-git-send-email-weil@mail.berlios.de>
	<20110505130051.GC30119@redhat.com>
In-Reply-To: <20110505130051.GC30119@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/10] eepro100: Pad received short
	frames
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 05.05.2011 15:00, schrieb Michael S. Tsirkin:
> On Sat, Apr 30, 2011 at 10:40:07PM +0200, Stefan Weil wrote:
>> QEMU sends frames smaller than 60 bytes to ethernet nics.
>> This should be fixed in the networking code because normally
>> such frames are rejected by real NICs and their emulations.
>> To avoid this behaviour, other NIC emulations pad received
>> frames. This patch enables this workaround for eepro100, too.
>>
>> All related code is marked with CONFIG_PAD_RECEIVED_FRAMES,
>> so emulation of the correct handling for short frames can
>> be restored as soon as QEMU's networking code is fixed.
>>
>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> Applied, I tweaked the comment a bit as we don't intend
> to change it in qemu. But go ahead and keep the ifdef around
> if you like.

The new comment is ok, thanks.

Cheers,
Stefan W.