From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QIdJt-0008L9-D5
	for qemu-devel@nongnu.org; Sat, 07 May 2011 04:57:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QIdJr-000344-Uj
	for qemu-devel@nongnu.org; Sat, 07 May 2011 04:57:01 -0400
Received: from moutng.kundenserver.de ([212.227.17.10]:63195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QIdJr-00033r-Jk
	for qemu-devel@nongnu.org; Sat, 07 May 2011 04:56:59 -0400
Message-ID: <4DC50954.4060601@mail.berlios.de>
Date: Sat, 07 May 2011 10:56:52 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1304708747-3692-1-git-send-email-pedro.scarapiccha@br.flextronics.com>
	<BANLkTin3R0oFKn8mB4eXQWgG-sWUQurzmg@mail.gmail.com>
In-Reply-To: <BANLkTin3R0oFKn8mB4eXQWgG-sWUQurzmg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix a memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pedro Scarapicchia Junior <pedro.scarapiccha@br.flextronics.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 07.05.2011 10:34, schrieb Stefan Hajnoczi:
> On Fri, May 6, 2011 at 8:05 PM, Pedro Scarapicchia Junior
> <pedrinho.rep51@gmail.com> wrote:
>> At v9fs_walk_complete(), the memory allocated at v9fs_walk() is not being
>> released leading system to crash due out of memory.
>>
>> This patch releases structure V9fsWalkState after v9fs_walk is complete.
>>
>> Signed-off-by: Pedro Scarapicchia Junior 
>> <pedro.scarapiccha@br.flextronics.com>
>> ---
>>  hw/9pfs/virtio-9p.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> Thanks for this patch. I suggest CCing Venkateswararao Jujjuri (JV)
> <jvrao@linux.vnet.ibm.com>, the virtio-9p maintainer (see MAINTAINERS
> file), on future patches so he can pick them up quickly.
>
> Stefan

Releasing the memory in v9fs_walk() were it was allocated
would be cleaner and easier to review. Is this not possible?

Stefan W.