From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1QIzMY-0007W9-91
	for qemu-devel@nongnu.org; Sun, 08 May 2011 04:29:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1QIzMX-00080N-G5
	for qemu-devel@nongnu.org; Sun, 08 May 2011 04:29:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64308)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1QIzMX-00080G-9I
	for qemu-devel@nongnu.org; Sun, 08 May 2011 04:29:13 -0400
Message-ID: <4DC654DB.4050504@redhat.com>
Date: Sun, 08 May 2011 10:31:23 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1304799053-19137-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1304799053-19137-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb-linux: Add missing break statement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

Thanks, good catch.

Acked-by: Hans de Goede <hdegoede@redhat.com>

On 05/07/2011 10:10 PM, Stefan Weil wrote:
> cppcheck report:
> usb-linux.c:661: warning: Redundant assignment of "len" in switch
>
> Please check whether adding a break statement
> is the correct solution for this warning.
>
> Cc: Hans de Goede<hdegoede@redhat.com>
> Cc: Gerd Hoffmann<kraxel@redhat.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
>   usb-linux.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index 36a01ea..0ef1d26 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -659,6 +659,7 @@ static int usb_host_handle_iso_data(USBHostDevice *s, USBPacket *p, int in)
>                           switch(errno) {
>                           case ETIMEDOUT:
>                               len = USB_RET_NAK;
> +                            break;
>                           case EPIPE:
>                           default:
>                               len = USB_RET_STALL;