From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QJ6Jj-0002P0-VV
	for qemu-devel@nongnu.org; Sun, 08 May 2011 11:54:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QJ6Jj-0004zj-0h
	for qemu-devel@nongnu.org; Sun, 08 May 2011 11:54:47 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:50235)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QJ6Ji-0004zV-KO
	for qemu-devel@nongnu.org; Sun, 08 May 2011 11:54:46 -0400
Message-ID: <4DC6BCC2.4020108@mail.berlios.de>
Date: Sun, 08 May 2011 17:54:42 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1304809179-7359-1-git-send-email-agraf@suse.de>
In-Reply-To: <1304809179-7359-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] USB: Fix build breakage in musb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

Am 08.05.2011 00:59, schrieb Alexander Graf:
> Today's git failed building for me. It looks like a mismatching function
> prototype definition.
>
> This patch fixes compilation of arm-softmmu for me.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> hw/usb-musb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/usb-musb.c b/hw/usb-musb.c
> index b30caeb..85a2b6f 100644
> --- a/hw/usb-musb.c
> +++ b/hw/usb-musb.c
> @@ -261,7 +261,7 @@
>
> static void musb_attach(USBPort *port);
> static void musb_detach(USBPort *port);
> -static void musb_schedule_cb(USBDevice *dev, USBPacket *p);
> +static inline void musb_schedule_cb(USBDevice *dev, USBPacket *p);
>
> static USBPortOps musb_port_ops = {
> .attach = musb_attach,

The patch fixes the warning, because now forward declaration and
function definition match, but it's not the correct approach.

Instead of adding 'inline' here, 'inline' should be removed from the 
definition.
The function musb_schedule_cb is used via a function pointer, so it is 
never inline.

Regards,
Stefan W.