From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJ7c3-0007vt-2N for qemu-devel@nongnu.org; Sun, 08 May 2011 13:17:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJ7c1-0003pK-RO for qemu-devel@nongnu.org; Sun, 08 May 2011 13:17:47 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:45222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJ7c1-0003pF-KJ for qemu-devel@nongnu.org; Sun, 08 May 2011 13:17:45 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p48HEnBP024008 for ; Sun, 8 May 2011 11:14:49 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p48HHbFV146528 for ; Sun, 8 May 2011 11:17:37 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p48BHA9U014536 for ; Sun, 8 May 2011 05:17:10 -0600 Message-ID: <4DC6D02F.6080401@linux.vnet.ibm.com> Date: Sun, 08 May 2011 10:17:35 -0700 From: Venkateswararao Jujjuri MIME-Version: 1.0 References: <1304799829-19555-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1304799829-19555-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers On 05/07/2011 01:23 PM, Stefan Weil wrote: > cppcheck report: > virtio-9p.c:197: warning: Redundant assignment of "flags" to itself > > Cc: Venkateswararao Jujjuri > Signed-off-by: Stefan Weil Reviewed-by: Venkateswararao Jujjuri BTW, New threading model will change these functions completely. But in the mean while, we can keep merging these fixes as they come. Thanks, JV > --- > hw/9pfs/virtio-9p.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index ac5a1d0..d31b34a 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid, > cred.fc_uid = uid; > cred.fc_gid = gid; > cred.fc_mode = mode& 07777; > - flags = flags; > return s->ops->open2(&s->ctx, fullname, flags,&cred); > }