* [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)
@ 2011-05-07 20:23 Stefan Weil
2011-05-08 17:17 ` Venkateswararao Jujjuri
2011-06-03 21:39 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2011-05-07 20:23 UTC (permalink / raw)
To: QEMU Developers; +Cc: Venkateswararao Jujjuri
cppcheck report:
virtio-9p.c:197: warning: Redundant assignment of "flags" to itself
Cc: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hw/9pfs/virtio-9p.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index ac5a1d0..d31b34a 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid,
cred.fc_uid = uid;
cred.fc_gid = gid;
cred.fc_mode = mode & 07777;
- flags = flags;
return s->ops->open2(&s->ctx, fullname, flags, &cred);
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)
2011-05-07 20:23 [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck) Stefan Weil
@ 2011-05-08 17:17 ` Venkateswararao Jujjuri
2011-06-03 21:39 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Venkateswararao Jujjuri @ 2011-05-08 17:17 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developers
On 05/07/2011 01:23 PM, Stefan Weil wrote:
> cppcheck report:
> virtio-9p.c:197: warning: Redundant assignment of "flags" to itself
>
> Cc: Venkateswararao Jujjuri<jvrao@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
Reviewed-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
BTW, New threading model will change these functions completely.
But in the mean while, we can keep merging these fixes as they come.
Thanks,
JV
> ---
> hw/9pfs/virtio-9p.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index ac5a1d0..d31b34a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid,
> cred.fc_uid = uid;
> cred.fc_gid = gid;
> cred.fc_mode = mode& 07777;
> - flags = flags;
> return s->ops->open2(&s->ctx, fullname, flags,&cred);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)
2011-05-07 20:23 [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck) Stefan Weil
2011-05-08 17:17 ` Venkateswararao Jujjuri
@ 2011-06-03 21:39 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2011-06-03 21:39 UTC (permalink / raw)
To: Stefan Weil; +Cc: Venkateswararao Jujjuri, QEMU Developers
On Sat, May 07, 2011 at 10:23:49PM +0200, Stefan Weil wrote:
> cppcheck report:
> virtio-9p.c:197: warning: Redundant assignment of "flags" to itself
>
> Cc: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/9pfs/virtio-9p.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index ac5a1d0..d31b34a 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid,
> cred.fc_uid = uid;
> cred.fc_gid = gid;
> cred.fc_mode = mode & 07777;
> - flags = flags;
>
> return s->ops->open2(&s->ctx, fullname, flags, &cred);
> }
> --
> 1.7.2.5
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-03 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-07 20:23 [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck) Stefan Weil
2011-05-08 17:17 ` Venkateswararao Jujjuri
2011-06-03 21:39 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).