From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Vesely <jano.vesely@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch
Date: Mon, 09 May 2011 09:55:24 +0200 [thread overview]
Message-ID: <4DC79DEC.50401@redhat.com> (raw)
In-Reply-To: <BANLkTik=gr0K9-_fOTqPQORo37xs2D+9Yg@mail.gmail.com>
On 05/06/11 10:07, Jan Vesely wrote:
> hi,
> using the modified (single line) patch only works half-way, it sets
> the value in status register (guess that's what that line does :))
> but hw interrupt is not generated.
>
> I tried adding uhci_update_irq and this patch:
> + s->status |= UHCI_STS_USBERR;
> + uhci_update_irq(s);
> works.
Good. Can you create a patch with a changelog entry & signed-off
please? I'll go queue it up then.
thanks,
Gerd
next prev parent reply other threads:[~2011-05-09 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 20:57 [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch Jan Vesely
2011-04-16 6:33 ` Brad Hards
2011-04-16 7:29 ` Jan Vesely
2011-04-16 8:40 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-05-05 12:05 ` [Qemu-devel] " Gerd Hoffmann
2011-05-06 8:07 ` Jan Vesely
2011-05-09 7:55 ` Gerd Hoffmann [this message]
2011-05-09 10:16 ` Jan Vesely
2011-05-09 11:43 ` Gerd Hoffmann
2011-05-11 11:33 ` Jan Vesely
2011-05-12 9:28 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC79DEC.50401@redhat.com \
--to=kraxel@redhat.com \
--cc=jano.vesely@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).